linux-kernel - Re: [PATCH] vfs: don't call ima_file_check() unconditionally in nfsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1266330802.4416.9.camel@dyn9002018117.watson.ibm.com>
Date:	Tue, 16 Feb 2010 09:33:22 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	James Morris <jmorris@...ei.org>, linux-kernel@...r.kernel.org,
	Mimi Zohar <zohar@...ibm.com>
Subject: Re: [PATCH] vfs: don't call ima_file_check() unconditionally in
 nfsd_open()

On Mon, 2010-02-15 at 18:07 -0500, Chuck Ebbert wrote:
> From: Chuck Ebbert <cebbert@...hat.com>
> 
> vfs: don't call ima_file_check() unconditionally in nfsd_open()
> 
> commit 1e41568d7378d1ba8c64ba137b9ddd00b59f893a ("Take ima_path_check()
> in nfsd past dentry_open() in nfsd_open()") moved this code back to its
> original location but missed the "else".
> 
> Signed-off-by: Chuck Ebbert <cebbert@...hat.com>

Thanks for catching it.

Signed-off-by: Mimi Zohar <zohar@...ibm.com>

> --- linux-2.6.32.noarch.orig/fs/nfsd/vfs.c
> +++ linux-2.6.32.noarch/fs/nfsd/vfs.c
> @@ -752,7 +752,8 @@ nfsd_open(struct svc_rqst *rqstp, struct
>  			    flags, current_cred());
>  	if (IS_ERR(*filp))
>  		host_err = PTR_ERR(*filp);
> -	host_err = ima_file_check(*filp, access);
> +	else
> +		host_err = ima_file_check(*filp, access);
>  out_nfserr:
>  	err = nfserrno(host_err);
>  out:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/