linux-kernel - Re: [PATCH 1/4] power_supply: bq27x00: remove double endian swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100216162223.GA28375@enneenne.com>
Date:	Tue, 16 Feb 2010 17:22:24 +0100
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Grazvydas Ignotas <notasas@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Anton Vorontsov <avorontsov@...mvista.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 1/4] power_supply: bq27x00: remove double endian swap

On Fri, Feb 12, 2010 at 11:56:46PM +0200, Grazvydas Ignotas wrote:
> The bq27x00 registers are little endian, so just read them as such
> and don't do double endian swap on LE machines.
> 
> This also gets rid of strange looking shift that was done after
> reading 8bit register because endian swap in bq27x00_read() was
> messing it up.
> 
> Signed-off-by: Grazvydas Ignotas <notasas@...il.com>

Acked-by: Rodolfo Giometti <giometti@...ux.it>

-- 

GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/