linux-kernel - Re: [PATCH -next] staging/vmwgfx: depends on FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B7B32C4.6070802@oracle.com>
Date:	Tue, 16 Feb 2010 16:05:24 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Greg KH <gregkh@...e.de>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH -next] staging/vmwgfx: depends on FB

On 02/16/10 15:22, Greg KH wrote:
> On Tue, Feb 16, 2010 at 03:15:22PM -0800, Randy Dunlap wrote:
>> On 02/16/10 15:05, Greg KH wrote:
>>> On Tue, Feb 16, 2010 at 02:59:11PM -0800, Randy Dunlap wrote:
>>>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>>>
>>>> vmwfgx uses framebuffer interfaces, so it should depend on FB.
>>>> Otherwise it has these build errors (e.g., when CONFIG_FB=m):
>>>>
>>>> drivers/built-in.o: In function `vmw_fb_close':
>>>> (.text+0x97713): undefined reference to `unregister_framebuffer'
>>>> drivers/built-in.o: In function `vmw_fb_close':
>>>> (.text+0x97754): undefined reference to `framebuffer_release'
>>>> drivers/built-in.o: In function `vmw_fb_init':
>>>> (.text+0x97e1c): undefined reference to `framebuffer_alloc'
>>>> drivers/built-in.o: In function `vmw_fb_init':
>>>> (.text+0x9838d): undefined reference to `register_framebuffer'
>>>> drivers/built-in.o: In function `vmw_fb_init':
>>>> (.text+0x9842a): undefined reference to `framebuffer_release'
>>>>
>>>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>>>> ---
>>>>  drivers/gpu/drm/vmwgfx/Kconfig |    2 +-
>>>
>>> This is not a drivers/staging/* file, so there's not much I can do with
>>> it.  It belongs to David Airlie.
>>
>> OK, I'll resend it to him, thanks.
>>
>> I think I was confused by drivers/staging/Kconfig:
>>
>> source "drivers/gpu/drm/vmwgfx/Kconfig"
>>
>> source "drivers/gpu/drm/nouveau/Kconfig"
>>
>>
>> Why are those lines there??
> 
> Because those modules are "hidden" behind the CONFIG_STAGING option.


oh well, that doesn't clarify anything.  :(

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/