linux-kernel - Re: s2disk hang update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Feb 2010 11:27:30 +0000
From:	Alan Jenkins <sourcejedi.lkml@...glemail.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Mel Gorman <mel@....ul.ie>, hugh.dickins@...cali.co.uk,
	Pavel Machek <pavel@....cz>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>
Subject: Re: s2disk hang update

On 2/16/10, Rafael J. Wysocki <rjw@...k.pl> wrote:
> On Tuesday 16 February 2010, Alan Jenkins wrote:
>> On 2/16/10, Alan Jenkins <sourcejedi.lkml@...glemail.com> wrote:
>> > On 2/15/10, Rafael J. Wysocki <rjw@...k.pl> wrote:
>> >> On Tuesday 09 February 2010, Alan Jenkins wrote:
>> >>> Perhaps I spoke too soon.  I see the same hang if I run too many
>> >>> applications.  The first hibernation fails with "not enough swap" as
>> >>> expected, but the second or third attempt hangs (with the same
>> >>> backtrace
>> >>> as before).
>> >>>
>> >>> The patch definitely helps though.  Without the patch, I see a hang
>> >>> the
>> >>> first time I try to hibernate with too many applications running.
>> >>
>> >> Well, I have an idea.
>> >>
>> >> Can you try to apply the appended patch in addition and see if that
>> >> helps?
>> >>
>> >> Rafael
>> >
>> > It doesn't seem to help.
>>
>> To be clear: It doesn't stop the hang when I hibernate with too many
>> applications.
>>
>> It does stop the same hang in a different case though.
>>
>> 1. boot with init=/bin/bash
>> 2. run s2disk
>> 3. cancel the s2disk
>> 4. repeat steps 2&3
>>
>> With the patch, I can run 10s of iterations, with no hang.
>> Without the patch, it soon hangs, (in disable_nonboot_cpus(), as always).
>>
>> That's what happens on 2.6.33-rc7.  On 2.6.30, there is no problem.
>> On 2.6.31 and 2.6.32 I don't get a hang, but dmesg shows an allocation
>> failure after a couple of iterations ("kthreadd: page allocation
>> failure. order:1, mode:0xd0").  It looks like it might be the same
>> stop_machine thread allocation failure that causes the hang.
>
> Have you tested it alone or on top of the previous one?  If you've tested it
> alone, please apply the appended one in addition to it and retest.
>
> Rafael

I did test with both patches applied together -

1. [Update] MM / PM: Force GFP_NOIO during suspend/hibernation and resume
2. "reducing the number of pages that we're going to keep preallocated by 20%"

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/