linux-kernel - Re: [PATCH 3/3] vt: Fix refcounting use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100217163135.120c4bc1@lxorguk.ukuu.org.uk>
Date:	Wed, 17 Feb 2010 16:31:35 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Richard Kennedy <richard@....demon.co.uk>
Cc:	Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] vt: Fix refcounting use

> This is the only bit that immediately stands out..
> maybe?
> 	if (rep || !tty) {
> 		if (tty)
> 			tty_kref_put(tty);
> 		return;
> 	}

tty_kref_put(NULL) is valid - otherwise a lot of other code (and
programmers) would go nuts..

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/