linux-kernel - Re: [PATCH 27/35] core: move early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B7B31F1.60203@zytor.com>
Date:	Tue, 16 Feb 2010 16:01:53 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 27/35] core: move early_res

On 02/16/2010 03:53 PM, Yinghai Lu wrote:
>>
>> All this does would seem is it would change a build failure into a
>> runtime panic.  I really fail to see how this is an improvement...
> 
> current only x86 support to early_res replace bootmem.
> 
> later if other arch is using that feature, it need to provide that get_max_mapped.
> 

If so, it would be better if this code isn't compiled at all on
platforms that doesn't use it.  Masking a compile-time failure with a
runtime failure when the code isn't actually used doesn't seem like the
right thing.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/