linux-kernel - Re: [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a1002180412x6cc4f280u5444f013c6e3b670@mail.gmail.com>
Date:	Thu, 18 Feb 2010 07:12:08 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	"David S . Miller" <davem@...emloft.net>,
	Paul Mundt <lethal@...ux-sh.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic

On Thu, Feb 18, 2010 at 07:09, Heiko Carstens wrote:
> On Thu, Feb 18, 2010 at 06:18:20AM -0500, Mike Frysinger wrote:
>> On Thu, Feb 18, 2010 at 06:13, Frederic Weisbecker wrote:
>> > --- a/arch/Kconfig
>> > +++ b/arch/Kconfig
>> > @@ -121,6 +121,9 @@ config HAVE_DMA_ATTRS
>> >  config USE_GENERIC_SMP_HELPERS
>> >        bool
>> >
>> > +config HAVE_REGS_AND_STACK_ACCESS_API
>> > +       bool
>> > +
>>
>> could you add an appropriate help/comment so arch peeps know what
>> needs to be implemented before they can select this
>
> That's why I added the commit ID for the regs and stack access api
> to the changelog. imho that should be sufficient.
> Besides that the next commit would implement it for s390 as a
> blueprint for others. That is... for those that missed the initial
> x86 implementation.

people shouldnt have to dive into the changelog to try and divine
documentation.  it's hardly standard, so people fall on it in a
pima-last-resort kind of way.  being explicit in the file up front by
writing real documentation says other people a lot more time.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/