linux-kernel - Re: [RFC PATCH 3/3] genericirq: change ack/mask in irq_chip to take irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B7D7552.2010001@zytor.com>
Date:	Thu, 18 Feb 2010 09:13:54 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Yinghai Lu <yinghai@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	linux-kernel@...r.kernel.org, Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [RFC PATCH 3/3] genericirq: change ack/mask in irq_chip to take
 irq_desc in addition to irq

On 02/18/2010 09:04 AM, Eric W. Biederman wrote:
> 
> May I ask why these methods and why pass both irq and desc instead of
> just desc?
> 
> I think in the long run passing both irq and desc through several
> functions may incur some maintenance cost that it would be nice not to
> pay (register pressure and increased chance of typos).
> 

Indeed; if the IRQ number is needed the function should just get it from
desc->irq.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/