lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2010 17:52:59 +0000 From: Jonathan Cameron <jic23@....ac.uk> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> CC: Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: iio: Staticise non-exported functions On 02/18/10 17:19, Mark Brown wrote: > Staticise a number of functions which aren't exported outside their > source files, and also add a __user annotation for the buffer in > iio_event_chrdev_read(). Thanks, > Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com> Acked-by: Jonathan Cameron <jic23@....ac.uk> > --- > drivers/staging/iio/industrialio-core.c | 14 +++++++------- > drivers/staging/iio/trigger_consumer.h | 4 ++-- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c > index 4ff683a..b456dfc 100644 > --- a/drivers/staging/iio/industrialio-core.c > +++ b/drivers/staging/iio/industrialio-core.c > @@ -118,7 +118,7 @@ int iio_push_event(struct iio_dev *dev_info, > EXPORT_SYMBOL(iio_push_event); > > /* Generic interrupt line interrupt handler */ > -irqreturn_t iio_interrupt_handler(int irq, void *_int_info) > +static irqreturn_t iio_interrupt_handler(int irq, void *_int_info) > { > struct iio_interrupt *int_info = _int_info; > struct iio_dev *dev_info = int_info->dev_info; > @@ -252,10 +252,10 @@ void iio_remove_event_from_list(struct iio_event_handler_list *el, > } > EXPORT_SYMBOL(iio_remove_event_from_list); > > -ssize_t iio_event_chrdev_read(struct file *filep, > - char *buf, > - size_t count, > - loff_t *f_ps) > +static ssize_t iio_event_chrdev_read(struct file *filep, > + char __user *buf, > + size_t count, > + loff_t *f_ps) > { > struct iio_event_interface *ev_int = filep->private_data; > struct iio_detected_event_list *el; > @@ -313,7 +313,7 @@ error_ret: > return ret; > } > > -int iio_event_chrdev_release(struct inode *inode, struct file *filep) > +static int iio_event_chrdev_release(struct inode *inode, struct file *filep) > { > struct iio_handler *hand = iio_cdev_to_handler(inode->i_cdev); > struct iio_event_interface *ev_int = hand->private; > @@ -335,7 +335,7 @@ int iio_event_chrdev_release(struct inode *inode, struct file *filep) > return 0; > } > > -int iio_event_chrdev_open(struct inode *inode, struct file *filep) > +static int iio_event_chrdev_open(struct inode *inode, struct file *filep) > { > struct iio_handler *hand = iio_cdev_to_handler(inode->i_cdev); > struct iio_event_interface *ev_int = hand->private; > diff --git a/drivers/staging/iio/trigger_consumer.h b/drivers/staging/iio/trigger_consumer.h > index a02d70b..9d52d96 100644 > --- a/drivers/staging/iio/trigger_consumer.h > +++ b/drivers/staging/iio/trigger_consumer.h > @@ -27,7 +27,7 @@ int iio_device_unregister_trigger_consumer(struct iio_dev *dev_info); > * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers > * @dev_info: iio_dev associated with the device that will consume the trigger > **/ > -int iio_device_register_trigger_consumer(struct iio_dev *dev_info) > +static int iio_device_register_trigger_consumer(struct iio_dev *dev_info) > { > return 0; > }; > @@ -36,7 +36,7 @@ int iio_device_register_trigger_consumer(struct iio_dev *dev_info) > * iio_device_unregister_trigger_consumer() - reverse the registration process > * @dev_info: iio_dev associated with the device that consumed the trigger > **/ > -int iio_device_unregister_trigger_consumer(struct iio_dev *dev_info) > +static int iio_device_unregister_trigger_consumer(struct iio_dev *dev_info) > { > return 0; > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists