linux-kernel - Re: [PATCH] drivers/media/radio/si470x/radio-si470x-usb.c fix use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Feb 2010 20:16:12 +0100
From:	Tobias Lorenz <tobias.lorenz@....net>
To:	Darren Jenkins <darrenrjenkins@...il.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Douglas Schilling Landgraf <dougsland@...hat.com>,
	linux-media@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] drivers/media/radio/si470x/radio-si470x-usb.c fix use after free

Hello Darren,

thanks for the patch. It was already pulled into the main repository.

Acked-by: Tobias Lorenz <tobias.lorenz@....net>

Bye,
Toby

Am Donnerstag 11 Februar 2010 12:07:53 schrieb Darren Jenkins:
> In si470x_usb_driver_disconnect() radio->disconnect_lock is accessed
> after it is freed. This fixes the problem.
> 
> Coverity CID: 2530
> 
> Signed-off-by: Darren Jenkins <darrenrjenkins@...il.com>
> ---
>  drivers/media/radio/si470x/radio-si470x-usb.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio-si470x-usb.c
> index a96e1b9..1588a9d 100644
> --- a/drivers/media/radio/si470x/radio-si470x-usb.c
> +++ b/drivers/media/radio/si470x/radio-si470x-usb.c
> @@ -842,9 +842,11 @@ static void si470x_usb_driver_disconnect(struct usb_interface *intf)
>  		kfree(radio->int_in_buffer);
>  		video_unregister_device(radio->videodev);
>  		kfree(radio->buffer);
> +		mutex_unlock(&radio->disconnect_lock);
>  		kfree(radio);
> +	} else {
> +		mutex_unlock(&radio->disconnect_lock);
>  	}
> -	mutex_unlock(&radio->disconnect_lock);
>  }
>  
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/