linux-kernel - drivers/backlight/lcd.c vs drivers/backlight/backlight.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f9d2a5e11002182352ydb439c5j9684e03e6890257@mail.gmail.com>
Date:	Fri, 19 Feb 2010 00:52:05 -0700
From:	Russ Dill <russ.dill@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	mjg@...hat.com
Subject: drivers/backlight/lcd.c vs drivers/backlight/backlight.c

When these were initially checked in, they were basically the same,
except one was called backlight, the other lcd, one controlled
brightness, the other contrast.

Over time, they have diverged. backlight has sysfs_notify support,
provides uevent changes, and suspend/resume support. lcd has received
set_mode support.

Having a device that has variable brightness and needs info on video
timings, I'm confused at what to do. It seems other driver writers
chose to register and lcd device and a backlight device. It seems like
there is a lot of unnecessary duplication going on here. Should I
create my driver with both interfaces? Maybe with just use lcd and
pretend contrast is brightness, or maybe use backlight and add
set_mode support.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/