lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Feb 2010 11:53:17 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Cc: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>, Tilman Schmidt <tilman@...p.cc> Subject: [PATCHv2] drivers: isdn: use new hex_to_bin() method From: Andy Shevchenko <ext-andriy.shevchenko@...ia.com> Get rid of own implementation of hex_to_bin(). Please note it requires to have hex_to_bin() introduced by one of previous patch [1] which is not applied yet. [1] http://patchwork.kernel.org/patch/80404/ Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@...ia.com> Cc: Tilman Schmidt <tilman@...p.cc> --- drivers/isdn/gigaset/capi.c | 13 +------------ 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c index 83c4e2f..82ee085 100644 --- a/drivers/isdn/gigaset/capi.c +++ b/drivers/isdn/gigaset/capi.c @@ -169,17 +169,6 @@ static inline void ignore_cstruct_param(struct cardstate *cs, _cstruct param, } /* - * convert hex to binary - */ -static inline u8 hex2bin(char c) -{ - int result = c & 0x0f; - if (c & 0x40) - result += 9; - return result; -} - -/* * convert an IE from Gigaset hex string to ETSI binary representation * including length byte * return value: result length, -1 on error @@ -190,7 +179,7 @@ static int encode_ie(char *in, u8 *out, int maxlen) while (*in) { if (!isxdigit(in[0]) || !isxdigit(in[1]) || l >= maxlen) return -1; - out[++l] = (hex2bin(in[0]) << 4) + hex2bin(in[1]); + out[++l] = (hex_to_bin(in[0]) << 4) + hex_to_bin(in[1]); in += 2; } out[0] = l; -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists