linux-kernel - Re: [PATCH v1 2/7] vsprintf: clarify comments for printf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B7ED334.5000603@xenotime.net>
Date:	Fri, 19 Feb 2010 10:06:44 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adam Belay <abelay@....edu>
Subject: Re: [PATCH v1 2/7] vsprintf: clarify comments for printf_spec flags

On 02/19/10 09:58, Bjorn Helgaas wrote:
> 
> Add clues about what the SMALL and SPECIAL flags do.
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>
> ---
> 
>  lib/vsprintf.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 3b8aeec..212d047 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -381,8 +381,8 @@ static noinline char *put_dec(char *buf, unsigned long long num)
>  #define PLUS	4		/* show plus */
>  #define SPACE	8		/* space if plus */
>  #define LEFT	16		/* left justified */
> -#define SMALL	32		/* Must be 32 == 0x20 */
> -#define SPECIAL	64		/* 0x */
> +#define SMALL	32		/* use lowercase in hex (must be 32 == 0x20) */
> +#define SPECIAL	64		/* prefix hex with "0x", octal with "0 */

might as well do:						octal with "0" */


>  
>  enum format_type {
>  	FORMAT_TYPE_NONE, /* Just a string part */


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/