linux-kernel - Re: [PATCH 1/3] sdhci: Implement CAP_CLOCK_BASE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100219201100.GA17881@oksana.dev.rtsoft.ru>
Date:	Fri, 19 Feb 2010 23:11:00 +0300
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	David Vrabel <david.vrabel@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Richard Röjfors 
	<richard.rojfors.ext@...ean-labs.com>,
	Pierre Ossman <pierre@...man.eu>, Ben Dooks <ben@...tec.co.uk>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] sdhci: Implement CAP_CLOCK_BASE_BROKEN quirk

On Fri, Feb 19, 2010 at 07:55:30PM +0000, David Vrabel wrote:
> Anton Vorontsov wrote:
> > Some hosts (e.g. as found in CNS3xxx SOCs) report wrong value in
> > CLOCK_BASE capability field, and currently there is no way to
> > force the SDHCI core to use the platform-provided base clock value.
> 
> I don't think this needs a new quirk. Change the sdhci driver to check
> if the platform provides a value before reading the standard register.

Well, Pierre once said that by default we should conform to the
SDHCI spec, and any diviations from the spec should be handled by
the quirks:

http://linux.derkeiler.com/Mailing-Lists/Kernel/2009-02/msg03385.html

Spec clearly states that base clock == 0 is the case when we should
fall back to the platform-provided clocks.

So, for controllers that conform to the spec, following might be
true:

- Platform provides its own (alternate) clock, but
- SDHCI block choose not to use it, and doesn't clear bits in the
  capability register
- Then the driver should not use the platform provided clock.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/