linux-kernel - [PATCH 04/18] sysctl extern cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100220141023.GC3195@darkstar>
Date:	Sat, 20 Feb 2010 22:10:23 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	David Howells <dhowells@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	James Morris <jmorris@...ei.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 04/18] sysctl extern cleanup - binfmts

Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move core_uses_pid/core_pattern/core_pipe_limit extern declarations
to linux/binfmts.h
suid_dumpable is declared in binfmts.h already.

Signed-off-by: Dave Young <hidave.darkstar@...il.com>
---
 include/linux/binfmts.h |    6 ++++++
 kernel/sysctl.c         |    5 +----
 2 files changed, 7 insertions(+), 4 deletions(-)

--- linux-2.6.32.orig/kernel/sysctl.c	2010-02-20 14:06:33.374900066 +0800
+++ linux-2.6.32/kernel/sysctl.c	2010-02-20 14:06:42.621567640 +0800
@@ -56,6 +56,7 @@
 #include <linux/rcustring.h>
 #include <linux/signal.h>
 #include <linux/threads.h>
+#include <linux/binfmts.h>
 
 #include <asm/uaccess.h>
 #include <asm/processor.h>
@@ -70,10 +71,6 @@
 #if defined(CONFIG_SYSCTL)
 
 /* External variables not in a header file. */
-extern int core_uses_pid;
-extern int suid_dumpable;
-extern char *core_pattern;
-extern unsigned int core_pipe_limit;
 extern int pid_max;
 extern int min_free_kbytes;
 extern int pid_max_min, pid_max_max;
--- linux-2.6.32.orig/include/linux/binfmts.h	2010-02-20 14:02:26.958258402 +0800
+++ linux-2.6.32/include/linux/binfmts.h	2010-02-20 14:06:42.621567640 +0800
@@ -20,6 +20,12 @@ struct pt_regs;
 #ifdef __KERNEL__
 #include <linux/list.h>
 
+#ifdef CONFIG_SYSCTL
+extern int core_uses_pid;
+extern char *core_pattern;
+extern unsigned int core_pipe_limit;
+#endif
+
 #define CORENAME_MAX_SIZE 128
 
 /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/