linux-kernel - Re: [PATCH] Gpu: drm: fix buffer overflow in nouveau

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87aav3wug8.fsf@riseup.net>
Date:	Sat, 20 Feb 2010 20:58:15 +0100
From:	Francisco Jerez <currojerez@...eup.net>
To:	chris.nicholson@...ck.org.uk
Cc:	airlied@...ux.ie, bskeggs@...hat.com, madman2003@...il.com,
	koriakin@...4.net, tacconet@...ero.it,
	dri-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c

chris.nicholson@...ck.org.uk writes:

> From: Chris Nicholson <chris@...t.cnick.org.uk>
>
> This is a patch to the nouveau_bios.c file that fixes up a
> buffer overflow
>
This bug was already fixed upstream (774baeb0ba92bcb082f9868726a27a015c9a0897).
In any case, thank you.

> Signed-off-by: Chris Nicholson <chris.nicholson@...ck.org.uk>
> ---
>  drivers/gpu/drm/nouveau/nouveau_bios.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 0e9cd1d..c1cee91 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -762,7 +762,7 @@ static uint32_t get_tmds_index_reg(struct drm_device *dev, uint8_t mlv)
>  			dacoffset ^= 8;
>  		return 0x6808b0 + dacoffset;
>  	} else {
> -		if (mlv > ARRAY_SIZE(pramdac_table)) {
> +		if (mlv >= ARRAY_SIZE(pramdac_table)) {
>  			NV_ERROR(dev, "Magic Lookup Value too big (%02X)\n",
>  									mlv);
>  			return 0;


Content of type "application/pgp-signature" skipped