linux-kernel - Re: [PATCH] scripts: improve checkstack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B7F90AA.8050306@redhat.com>
Date:	Sat, 20 Feb 2010 15:35:06 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"Luis R. Rodriguez" <lrodriguez@...eros.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Uwe Kleine-KÃ¶nig 
	<u.kleine-koenig@...gutronix.de>,
	"Robert P. J. Day" <rpjday@...shcourse.ca>,
	Arnd Bergmann <arnd@...db.de>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Hui Zhu <teawater@...il.com>,
	Ozan Ãaglayan <ozan@...dus.org.tr>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Li Hong <lihong.hi@...il.com>, Ingo Molnar <mingo@...e.hu>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Matt Fleming <matt@...sole-pimps.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: improve checkstack

Stephen Hemminger wrote:
> Turn on strict checking, and get rid of annoying use of prototype.
> Fix syntax error in declaration
> 
> Use efficient sort algorithm by using schwartzian transform.
>   http://en.wikipedia.org/wiki/Schwartzian_transform


Yeah, the idea is good, this can also make it more perlish. ;)

But...


> -print sort bysize @stack;
> +# Use Schwartzian transform to sort by last field (size)
> +print map { $_->[0] }
> +      sort { $b->[1] <=> $a->[1] }
> +      map { [$_, /:\t*(\d+)$/] } @stack;

This regex here is not strictly the same as before.

Can we just keep the original regex? If not, what's wrong?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/