linux-kernel - Re: [PATCH -mm 09/17] sysctl extern cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 21 Feb 2010 08:58:10 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Dipankar Sarma <dipankar@...ibm.com>, Ingo Molnar <mingo@...e.hu>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Josh Triplett <josh@...htriplett.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	James Morris <jmorris@...ei.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 09/17] sysctl extern cleanup - rcu

On Sun, Feb 21, 2010 at 10:24:12PM +0800, Dave Young wrote:
> Extern declarations in sysctl.c should be move to their own head file,
> and then include them in relavant .c files.
> 
> Move rcutorture_runnable extern declaration to linux/rcupdate.h

Reviewed-by: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>

> Signed-off-by: Dave Young <hidave.darkstar@...il.com>
> Acked-by: Josh Triplett <josh@...htriplett.org>
> ---
>  include/linux/rcupdate.h |    4 ++++
>  kernel/sysctl.c          |    3 ---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> --- linux-2.6.32.orig/include/linux/rcupdate.h	2010-02-21 09:35:58.013190490 +0800
> +++ linux-2.6.32/include/linux/rcupdate.h	2010-02-21 10:03:53.296358225 +0800
> @@ -41,6 +41,10 @@
>  #include <linux/lockdep.h>
>  #include <linux/completion.h>
> 
> +#ifdef CONFIG_RCU_TORTURE_TEST
> +extern int rcutorture_runnable; /* for sysctl */
> +#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
> +
>  /**
>   * struct rcu_head - callback structure for use with RCU
>   * @next: next update requests in a list
> --- linux-2.6.32.orig/kernel/sysctl.c	2010-02-21 09:58:40.029722800 +0800
> +++ linux-2.6.32/kernel/sysctl.c	2010-02-21 10:01:30.257204779 +0800
> @@ -75,9 +75,6 @@
> 
>  /* External variables not in a header file. */
>  extern int max_threads;
> -#ifdef CONFIG_RCU_TORTURE_TEST
> -extern int rcutorture_runnable;
> -#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
>  #ifdef CONFIG_BLOCK
>  extern int blk_iopoll_enabled;
>  #endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/