linux-kernel - Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes" causes gobi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1002211627430.32083-100000@netrider.rowland.org>
Date:	Sun, 21 Feb 2010 16:28:54 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Oliver Neukum <oliver@...kum.org>
cc:	Anssi Hannula <anssi.hannula@....fi>,
	Matthew Garrett <mjg59@...f.ucam.org>, <dvomlehn@...co.com>,
	<gregkh@...e.de>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes"
 causes gobi_loader to hang

On Sat, 20 Feb 2010, Oliver Neukum wrote:

> Am Samstag, 20. Februar 2010 17:03:41 schrieb Anssi Hannula:
> > > But something must kill your last URB.
> > > You are not using autosuspend are you?
> > 
> > Don't know, usbcore has autosuspend=2 and the gobi device has autosuspend=2 
> > and supports_autosuspend=1.
> 
> What is the content of "level"?
> 
> > > Can load usbserial with "debug=1"?
> > 
> > Here's the end of dmesg when running with that option:
> > http://stuff.onse.fi/gobi2000/gobi-regression.dmesg.log
> > 
> > This is again with the gobi_loader with extra sleep added in the beginning. 
> > Otherwise it hangs (which is the actual original problem).
> 
> That log makes sure that the final cancellation comes from closing
> the file. Is that a log of a working run?

Could this simply be one of those cases where the device file is closed 
just after the final write URB is submitted but before it can complete, 
so the URB gets cancelled and the data isn't transferred?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/