linux-kernel - Re: [PATCH 11/11] KVM: SVM: Don't call instruction emulator for invd and wbinvd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B81205D.1070608@redhat.com>
Date:	Sun, 21 Feb 2010 14:00:29 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Joerg Roedel <joro@...tes.org>
CC:	Joerg Roedel <joerg.roedel@....com>,
	Marcelo Tosatti <mtosatti@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] KVM: SVM: Don't call instruction emulator for	invd
 and wbinvd

On 02/21/2010 01:37 PM, Joerg Roedel wrote:
> On Sun, Feb 21, 2010 at 11:53:14AM +0200, Avi Kivity wrote:
>    
>> On 02/19/2010 05:23 PM, Joerg Roedel wrote:
>>      
>>> There is an intercept for WBINVD and INVD in SVM so we don't
>>> need the instruction emulator. The primary reason is that
>>> the current instruction emulator fails to emulate these
>>> instructions and the rip is not advanced.
>>>
>>>        
>> The bios (at least bochs bios) does have wbinvd, so this ought to work.
>>      
> Weird. For some reason the Windows 7 XP emulation was executing wbinvd
> which caused an nested intercept for the host level and the rip was not
> advanced. So the nested guest did not advance and just produces wbinvd
> intercepts all the time.
>    

Has the guest enabled wbinvd interception?  Perhaps not, so kvm has to 
emulate wbinvd in the nested guest context, which is likely the only 
case that we're called to do this.  So the problem might be in emulating 
within the nested guest.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/