linux-kernel - Re: [PATCH 1/1] ftrace - add support for tracing_thresh to function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1266850663.24271.4425.camel@gandalf.stny.rr.com>
Date:	Mon, 22 Feb 2010 09:57:43 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Tim Bird <tim.bird@...sony.com>,
	linux kernel <linux-kernel@...r.kernel.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 1/1] ftrace - add support for tracing_thresh to
 function_graph tracer

On Sat, 2010-02-20 at 15:43 +0100, Frederic Weisbecker wrote:
> 
> Instead of having yet another check here, may be should we
> have a dedicated stub trace_graph_entry?
> 
> 
> 
> > @@ -254,6 +263,10 @@ static void __trace_graph_return(struct trace_array *tr,
> >  	if (unlikely(__this_cpu_read(per_cpu_var(ftrace_cpu_disabled))))
> >  		return;
> >  
> > +	if (tracing_thresh &&
> > +		(trace->rettime - trace->calltime < tracing_thresh))
> > +		return;
> > +
> 
> 
> 
> And perhaps we can do the same for the return handler?
> We could have a trace_graph_return_threshold that
> performs the above check and then relies on trace_graph_return.

So you mean to register a different type of function to the graph tracer
if trace_thresh is enabled? That does sound like a better idea.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/