linux-kernel - Re: [PATCH 04/10] namespace: perlcritic warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100222084148.062bc337@nehalam>
Date:	Mon, 22 Feb 2010 08:41:48 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Hui Zhu <teawater@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Luis R. Rodriguez" <lrodriguez@...eros.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Uwe Kleine-KĂśnig 
	<u.kleine-koenig@...gutronix.de>,
	"Robert P. J. Day" <rpjday@...shcourse.ca>,
	WANG Cong <amwang@...hat.com>, Arnd Bergmann <arnd@...db.de>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Ozan Ăaglayan <ozan@...dus.org.tr>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Li Hong <lihong.hi@...il.com>, Ingo Molnar <mingo@...e.hu>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Matt Fleming <matt@...sole-pimps.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/10] namespace: perlcritic warnings

On Sat, 20 Feb 2010 16:26:24 +0800
Hui Zhu <teawater@...il.com> wrote:

> On Sat, Feb 20, 2010 at 01:52, Stephen Hemminger <shemminger@...tta.com> wrote:
> > Use local file handle not global.
> > Make loop and other variables local in scope.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> >
> >
> > --- a/scripts/namespace.pl      2010-02-19 08:59:00.432184740 -0800
> > +++ b/scripts/namespace.pl      2010-02-19 09:05:52.672644797 -0800
> > @@ -175,12 +175,11 @@ sub do_nm
> >        }
> >        if (! -e "$source.c" && ! -e "$source.S") {
> >                # No obvious source, exclude the object if it is conglomerate
> > -               if (! open(OBJDUMPDATA, "$objdump $basename|")) {
> > -                       printf STDERR "$objdump $fullname failed $!\n";
> > -                       return;
> > -               }
> > +               open(my $objdumpdata, "$objdump $basename|")
> > +                   or die "$objdump $fullname failed $!\n";
> 
> Looks it just want return, are you sure have to change it to die?

Read my previous comment 
> If objdump program is missing program should die with message
> to standard error and exit with non zero status, not continue on!  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/