linux-kernel - Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes" causes gobi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100222212458.69249775@lxorguk.ukuu.org.uk>
Date:	Mon, 22 Feb 2010 21:24:58 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Anssi Hannula <anssi.hannula@....fi>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oliver@...kum.org>,
	Matthew Garrett <mjg59@...f.ucam.org>, dvomlehn@...co.com,
	gregkh@...e.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial
 writes" causes gobi_loader to hang

> Yes, but does the tty interface guarantee that the data of one write call is 
> sent as one packet to the device?

Not usually but it can do. At least the core tty code supports this for
suitable ldiscs.

> If I understood this correctly, it seems the changes have caused it to now 
> concatenate short writes into one packet, which the device doesn't seem to 
> like.

If the device wants exactly bounded packets then for the firmware loader
tty is probably the wrong interface.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/