[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <961aa3351002230608l5d5cbf88v41b3d645cfafccd5@mail.gmail.com>
Date: Tue, 23 Feb 2010 23:08:07 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Dmitry Monakhov <dmonakhov@...nvz.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] failslab: add abitily to filter slab caches
2010/2/23 Dmitry Monakhov <dmonakhov@...nvz.org>:
> Akinobu Mita <akinobu.mita@...il.com> writes:
>
>> 2010/2/23 Dmitry Monakhov <dmonakhov@...nvz.org>:
>>> Example:
>>> echo 1 > /sys/kernel/slab/skbuff_head_cache/failslab
>>> echo 1 > /sys/kernel/debug/failslab/cache-filter
>>
>> Looks good.
>>
>> .Should we also support clearing the flag by
>> "echo 0 > /sys/kernel/slab/skbuff_head_cache/failslab" ?
> But it already does this, any output except "1" treated as '0'
> I've snipped this from trace option.
Oops, you are right.
>>
>>> +static ssize_t failslab_store(struct kmem_cache *s, const char *buf,
>>> + size_t length)
>>> +{
>>> + s->flags &= ~SLAB_FAILSLAB;
>>> + if (buf[0] == '1')
>>> + s->flags |= SLAB_FAILSLAB;
>>> + return length;
>>> +}
>>> +SLAB_ATTR(failslab);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists