linux-kernel - Re: [patch 1/3] vmscan: factor out page reference checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B83E6AC.8030306@redhat.com>
Date:	Tue, 23 Feb 2010 09:31:08 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Johannes Weiner <hannes@...xchg.org>
CC:	Minchan Kim <minchan.kim@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/3] vmscan: factor out page reference checks

On 02/23/2010 09:21 AM, Johannes Weiner wrote:

> From: Johannes Weiner<hannes@...xchg.org>
> Subject: vmscan: improve comment on mlocked page in reclaim
>
> Signed-off-by: Johannes Weiner<hannes@...xchg.org>
> ---
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 674a78b..819fff7 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -578,7 +578,10 @@ static enum page_references page_check_references(struct page *page,
>   	if (sc->order>  PAGE_ALLOC_COSTLY_ORDER)
>   		return PAGEREF_RECLAIM;
>
> -	/* Mlock lost isolation race - let try_to_unmap() handle it */
> +	/*
> +	 * Mlock lost the isolation race with us.  Let try_to_unmap()
> +	 * move the page to the unevictable list.
> +	 */
>   	if (vm_flags&  VM_LOCKED)
>   		return PAGEREF_RECLAIM;

Reviewed-by: Rik van Riel <riel@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/