linux-kernel - RE: [PATCH] ARM: misplaced parentheses?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A6D19A13FE030A409EC4362C172E091F0E935FDB@eseldmw101.eemea.ericsson.se>
Date:	Tue, 23 Feb 2010 16:03:27 +0100
From:	"Linus Walleij" <linus.walleij@...ricsson.com>
To:	"Roel Kluin" <roel.kluin@...il.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"LKML" <linux-kernel@...r.kernel.org>
Cc:	"Russell King - ARM Linux" <linux@....linux.org.uk>
Subject: RE: [PATCH] ARM: misplaced parentheses?

[Roel]

> The parentheses appear misplaced.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Correct?
> 
> diff --git a/arch/arm/mach-u300/gpio.c b/arch/arm/mach-u300/gpio.c
> index 0b35826..5f61fd4 100644
> --- a/arch/arm/mach-u300/gpio.c
> +++ b/arch/arm/mach-u300/gpio.c
> @@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
>  	for (i = 0; i < U300_GPIO_MAX; i++) {
>  		val = 0;
>  		for (j = 0; j < 8; j++)
> -			val |= 
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
> +			val |= 
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
>  		local_irq_save(flags);
>  		writel(val, virtbase + U300_GPIO_PXPER + i * 
> U300_GPIO_PORTX_SPACING);
>  		local_irq_restore(flags);

Acked-by: Linus Walleij <linus.walleij@...ricsson.com>

BTW this should go in through Russells patch tracker, can you
put it there?
http://www.arm.linux.org.uk/developer/patches/

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/