linux-kernel - Re: [RFC PATCH] VFS: Simplify truncate logic in do_filp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100223190551.GA6377@shell>
Date:	Tue, 23 Feb 2010 14:05:52 -0500
From:	Valerie Aurora <vaurora@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [RFC PATCH] VFS: Simplify truncate logic in do_filp_open()

On Mon, Feb 22, 2010 at 09:08:27PM +0000, Al Viro wrote:
> On Mon, Feb 22, 2010 at 03:35:51PM -0500, Valerie Aurora wrote:
> > The fact that may_open() could truncate a file gave me a lot of
> > heartburn when working on union mounts, so I was thrilled to see that
> > truncate handling has been moved out of may_open() in Al's for-next
> > tree.  However, it seems to me that the surrounding elaborate
> > mnt_want_write() dance is no longer needed?  If so, this also
> > simplifies Ogawa Hirofumi "Fix use-after-free of vfsmount by
> > mnt_drop_write()" patch.
> > 
> > Against Al's for-next branch.  Lightly tested, please review.
> 
> Val, anything around do_filp_open() should be on top of #untested.  The
> whole area gets rewritten there.

Nice!  That's a huge improvement.  I will happily rebase.

Thanks,

-VAL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/