linux-kernel - Re: [PATCH] m68k,m68knommu: missing asterisk?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10f740e81002222213n3ef9608frd81422cd9a74c04@mail.gmail.com>
Date:	Tue, 23 Feb 2010 07:13:33 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Peter 'p2' De Schrijver" <p2@...ian.org>,
	"Linux/m68k" <linux-m68k@...r.kernel.org>
Subject: Re: [PATCH] m68k,m68knommu: missing asterisk?

On Sat, Feb 20, 2010 at 01:37, Roel Kluin <roel.kluin@...il.com> wrote:
> An asterisk was missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Correct?

No, see arch/m68k/apollo/config.c:dn_dummy_hwclk().
Andrew: please dequeue.

>  arch/m68k/include/asm/apollohw.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/include/asm/apollohw.h b/arch/m68k/include/asm/apollohw.h
> index a1373b9..87e0cc4 100644
> --- a/arch/m68k/include/asm/apollohw.h
> +++ b/arch/m68k/include/asm/apollohw.h
> @@ -94,7 +94,7 @@ extern u_long timer_physaddr;
>
>  #define sio01 ((*(volatile struct SCN2681 *)(IO_BASE + sio01_physaddr)))
>  #define sio23 ((*(volatile struct SCN2681 *)(IO_BASE + sio23_physaddr)))
> -#define rtc (((volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
> +#define rtc ((*(volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
>  #define cpuctrl (*(volatile unsigned int *)(IO_BASE + cpuctrl_physaddr))
>  #define pica (IO_BASE + pica_physaddr)
>  #define picb (IO_BASE + picb_physaddr)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/