linux-kernel - Re: [PATCH 12/14] Regulators: wm8994 - clean up driver data after removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100224102044.GF18896@rakim.wolfsonmicro.main>
Date:	Wed, 24 Feb 2010 10:20:44 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Liam Girdwood <lrg@...mlogic.co.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/14] Regulators: wm8994 - clean up driver data after
 removal

On Tue, Feb 23, 2010 at 11:38:44PM -0800, Dmitry Torokhov wrote:
> It is a good tone to reset driver data after unbinding the device.

You mean "good style" here.  Anyway,

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

BTW, this patch is an example of the sort of stuff I'm talking about
with adding additional changes that aren't documented in the
changelog.  As well as nulling out the driver data you're also...

>  struct wm8994_ldo {
>  	int enable;
> -	int is_enabled;
> +	bool is_enabled;

...doing a conversion to bool here and...

> @@ -276,6 +278,7 @@ static struct platform_driver wm8994_ldo_driver = {
>  	.remove = __devexit_p(wm8994_ldo_remove),
>  	.driver		= {
>  		.name	= "wm8994-ldo",
> +		.owner	= THIS_MODULE,
>  	},

...adding this.  The change you mention in the changelog is a single
line edit but with these extra changes the overall diffstat becomes:

>  drivers/regulator/wm8994-regulator.c |   11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/