linux-kernel - Re: Reminder: [PATCH 1/1] Staging: samsung-laptop: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100224135833.GA22414@suse.de>
Date:	Wed, 24 Feb 2010 05:58:33 -0800
From:	Greg KH <gregkh@...e.de>
To:	Tom Van Braeckel <tomvanbraeckel@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: Reminder: [PATCH 1/1] Staging: samsung-laptop: fix coding style

"Reminder"?  What is that in the Subject: for?

On Wed, Feb 24, 2010 at 02:45:38PM +0100, Tom Van Braeckel wrote:
> Signed-off-by: Tom Van Braeckel <tomvanbraeckel@...il.com>
> ---
>  drivers/staging/samsung-
> laptop/samsung-laptop.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c
> b/drivers/staging/samsung-laptop/samsung-laptop.c
> index 4877138..dd7ea4c 100644
> --- a/drivers/staging/samsung-laptop/samsung-laptop.c
> +++ b/drivers/staging/samsung-laptop/samsung-laptop.c
> @@ -99,7 +99,8 @@ static struct rfkill *rfk;
> 
>  static int force;
>  module_param(force, bool, 0);
> -MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be
> loaded");

Your patch is line-wrapped :(


> +MODULE_PARM_DESC(force,
> +               "Disable the DMI check and forces the driver to be loaded");

And the tabs are not here either.

and also, someone already sent in this fix, sorry.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/