linux-kernel - Re: [PATCH -mmotm] cgroup: fix typo in error handling in cgroup_write_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6599ad831002240804m66adc27fy253e2b10d9867465@mail.gmail.com>
Date:	Wed, 24 Feb 2010 08:04:08 -0800
From:	Paul Menage <menage@...gle.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	containers@...ts.linux-foundation.org,
	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mmotm] cgroup: fix typo in error handling in 
	cgroup_write_event_control()

On Wed, Feb 24, 2010 at 5:31 AM, Kirill A. Shutemov
<kirill@...temov.name> wrote:
> Actually, we want to fput() cfile, if cfile is not NULL.
>
> Signed-off-by: Kirill A. Shutemov <kirill@...temov.name>

Thanks.

Acked-by: Paul Menage <menage@...gle.com>

> ---
>  kernel/cgroup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index d142524..049ce0d 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -3117,7 +3117,7 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
>        return 0;
>
>  fail:
> -       if (!cfile)
> +       if (cfile)
>                fput(cfile);
>
>        if (event && event->eventfd && !IS_ERR(event->eventfd))
> --
> 1.6.6.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/