| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100224190234.GD25304@core.coreip.homeip.net> Date: Wed, 24 Feb 2010 11:02:34 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> Cc: Liam Girdwood <lrg@...mlogic.co.uk>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 13/14] Regulators: wm8400 - cleanup platform driver data handling On Wed, Feb 24, 2010 at 10:25:49AM +0000, Mark Brown wrote: > On Tue, Feb 23, 2010 at 11:38:50PM -0800, Dmitry Torokhov wrote: > > Driver data set by platform_set_drvdata() is for private use of > > the driver currently bound to teh device and not for use by parent, > > subsystem and anyone else. > > > > Also have wm8400_register_regulator() accept 'sturct wm8400 *' > > instead of generic device structure. > > Nack due to this change - this change would make it impossible for > callers to actually call the function. Note that nothing including only > wm8400.h even has a struct declaration, much less defniition, for struct > wm8400. If you notice I added forward declaration of "struct wm8400" to wm8400.h thus users can pass around pointer to the structure. I really think we should refrain from passing naked 'struct device *' pointers as much as possible since it is error prone. Otherwise wm8400_register_regulator has no way of ensuting that passed 'dev' is indeed wm8400. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists