linux-kernel - [tip:x86/mrst] x86, pci: Add sanity check for PCI fixed bar probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tip-c54113823c777f035fa7444f8841fbccda4a5cc0@git.kernel.org>
Date:	Wed, 24 Feb 2010 19:04:49 GMT
From:	tip-bot for Jacob Pan <jacob.jun.pan@...el.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	jacob.jun.pan@...el.com, tglx@...utronix.de
Subject: [tip:x86/mrst] x86, pci: Add sanity check for PCI fixed bar probing

Commit-ID:  c54113823c777f035fa7444f8841fbccda4a5cc0
Gitweb:     http://git.kernel.org/tip/c54113823c777f035fa7444f8841fbccda4a5cc0
Author:     Jacob Pan <jacob.jun.pan@...el.com>
AuthorDate: Wed, 24 Feb 2010 09:42:50 -0800
Committer:  H. Peter Anvin <hpa@...or.com>
CommitDate: Wed, 24 Feb 2010 11:01:34 -0800

x86, pci: Add sanity check for PCI fixed bar probing

While probing for the PCI fixed BAR capability in the extended PCI
configuration space we need to make sure raw_pci_ext_ops is
actually initialized.

Signed-off-by: Jacob Pan <jacob.jun.pan@...el.com>
LKML-Reference: <43F901BD926A4E43B106BF17856F0755A321E8F7@...msx508.amr.corp.intel.com>
Signed-off-by: H. Peter Anvin <hpa@...or.com>
---
 arch/x86/pci/mrst.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c
index 6e9e1a3..8bf2fcb 100644
--- a/arch/x86/pci/mrst.c
+++ b/arch/x86/pci/mrst.c
@@ -57,6 +57,10 @@ static int fixed_bar_cap(struct pci_bus *bus, unsigned int devfn)
 	u32 pcie_cap = 0, cap_data;
 
 	pos = PCIE_CAP_OFFSET;
+
+	if (!raw_pci_ext_ops)
+		return 0;
+
 	while (pos) {
 		if (raw_pci_ext_ops->read(pci_domain_nr(bus), bus->number,
 					  devfn, pos, 4, &pcie_cap))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/