linux-kernel - Re: [PATCH 11/11] KVM: SVM: Optimize nested svm msrpm merging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100224193700.GE3168@amd.com>
Date:	Wed, 24 Feb 2010 20:37:01 +0100
From:	Joerg Roedel <joerg.roedel@....com>
To:	Alexander Graf <agraf@...e.de>
CC:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] KVM: SVM: Optimize nested svm msrpm merging

On Wed, Feb 24, 2010 at 08:27:50PM +0100, Alexander Graf wrote:
> > +	static const u32 msrpm_offsets[] = {
> > +		0x0000002c, /* SYSENTER_CS */
> > +
> > +		0x00000038, /* LASTBRANCHFROMIP
> > +			       LASTBRANCHTOIP
> > +			       LASTINTFROMIP
> > +			       LASTINTTOIP */
> > +
> > +		0x00000820, /* STAR
> > +			       LSTAR
> > +			       CSTAR
> > +			       SYSCALL_MASK */
> > +
> > +		0x00000840, /* FS_BASE
> > +			       GS_BASE
> > +			       KERNEL_GS_BASE */
> > +
> > +		0xffffffff, /* End of List */
> 
> Isn't there such a list around somewhere already? We really should
> only keep this list once throughout the whole code. If necessary, just
> create the list on the fly when bits get set in the msrpm.

No, the list is hardcoded in 3 functions (as parameter of
set_msr_interception). I think about a variant to do this with a single
list. Probably I create a list of MSRs and check in
set_msr_interceptionm for it.

	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/