| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100224184505.1d8d3380@droptest.queued.net> Date: Wed, 24 Feb 2010 18:45:05 -0500 From: Andres Salomon <dilinger@...labora.co.uk> To: Ben Gardner <gardner.ben@...il.com> Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org> Subject: [PATCH] OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input Previously the MIC GPIO was set to output mode, and when checking the status after setting it we were checking OUTPUT_VAL. This worked, though I'm not quite sure why. Instead, if we actually check the READ_BACK value, it doesn't work unless the GPIO is in bidirectional mode. Thus, enable input mode as well. Signed-off-by: Andres Salomon <dilinger@...labora.co.uk> --- sound/pci/cs5535audio/cs5535audio_olpc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/pci/cs5535audio/cs5535audio_olpc.c b/sound/pci/cs5535audio/cs5535audio_olpc.c index 50da49b..f5574f2 100644 --- a/sound/pci/cs5535audio/cs5535audio_olpc.c +++ b/sound/pci/cs5535audio/cs5535audio_olpc.c @@ -157,6 +157,7 @@ int __devinit olpc_quirks(struct snd_card *card, struct snd_ac97 *ac97) return -EIO; } gpio_direction_output(OLPC_GPIO_MIC_AC, 0); + gpio_direction_input(OLPC_GPIO_MIC_AC); /* drop the original AD1888 HPF control */ memset(&elem, 0, sizeof(elem)); -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists