linux-kernel - Re: [PATCH] staging/serial2002: Fix filp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100224015657.GB13959@suse.de>
Date:	Tue, 23 Feb 2010 17:56:57 -0800
From:	Greg KH <gregkh@...e.de>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/serial2002: Fix filp_open usage

On Tue, Feb 23, 2010 at 03:04:42AM +0900, OGAWA Hirofumi wrote:
> 
> Signed-off-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
> ---
> 
>  drivers/staging/comedi/drivers/serial2002.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c
> --- linux-2.6/drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix	2010-02-22 23:22:27.000000000 +0900
> +++ linux-2.6-hirofumi/drivers/staging/comedi/drivers/serial2002.c	2010-02-22 23:22:27.000000000 +0900
> @@ -397,7 +397,7 @@ static void serial_2002_open(struct come
>  	char port[20];
>  
>  	sprintf(port, "/dev/ttyS%d", devpriv->port);
> -	devpriv->tty = filp_open(port, 0, O_RDWR);
> +	devpriv->tty = filp_open(port, O_RDWR, 0);

Oh wow that code is scary :)

I'll queue this up and remember to nuke the whole thing soon...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/