linux-kernel - Re: [tip:x86/mrst] x86, pic: Introduce legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100225113348.GF10212@elte.hu>
Date:	Thu, 25 Feb 2010 12:33:48 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Pan, Jacob jun" <jacob.jun.pan@...el.com>
Cc:	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/mrst] x86, pic: Introduce legacy_pic abstraction


* Pan, Jacob jun <jacob.jun.pan@...el.com> wrote:

> +static struct irq_chip dummy_pic_chip = {
> +	.name = "dummy pic",
> +	.mask = legacy_pic_uint_noop,
> +	.unmask = legacy_pic_uint_noop,
> +	.disable = legacy_pic_uint_noop,
> +	.mask_ack = legacy_pic_uint_noop,
> +};
> +static int legacy_pic_irq_pending_noop(unsigned int irq)
> +{
> +	return 0;
> +}
> +
> +struct legacy_pic null_legacy_pic = {
> +	.nr_legacy_irqs = 0,
> +	.chip = &dummy_pic_chip,
> +	.mask_all = legacy_pic_noop,
> +	.restore_mask = legacy_pic_noop,
> +	.init = legacy_pic_int_noop,
> +	.irq_pending = legacy_pic_irq_pending_noop,
> +	.make_irq = legacy_pic_uint_noop,
> +};
> +
> +struct legacy_pic default_legacy_pic = {
> +	.nr_legacy_irqs = NR_IRQS_LEGACY,
> +	.chip  = &i8259A_chip,
> +	.mask_all  = mask_8259A,
> +	.restore_mask = unmask_8259A,
> +	.init = init_8259A,
> +	.irq_pending = i8259A_irq_pending,
> +	.make_irq = make_8259A_irq,
> +};

Just a reminder: please use the vertical alignment style you can see with new 
pic/irqchip drivers:

struct irq_chip i8259A_chip = {
	.name		= "XT-PIC",
	.mask		= disable_8259A_irq,
	.disable	= disable_8259A_irq,
	.unmask		= enable_8259A_irq,
	.mask_ack	= mask_and_ack_8259A,
};

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/