linux-kernel - Re: [PATCH] nmi_watchdog: checkpatch.pl cleanups from earlier patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100225114226.GK10212@elte.hu>
Date:	Thu, 25 Feb 2010 12:42:26 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Don Zickus <dzickus@...hat.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org,
	gorcunov@...il.com, aris@...hat.com
Subject: Re: [PATCH] nmi_watchdog: checkpatch.pl cleanups from earlier patches


* Don Zickus <dzickus@...hat.com> wrote:

> Mostly copy/paste whitespace damage with a couple of nitpicks by the script.
> Fix the struct definition as requested by Ingo too.
> 
> Signed-off-by: Don Zickus <dzickus@...hat.com>
> --
> Ingo,
> 
> I don't know how you want this patch.  Like this to put on top or do you
> want me to repost everything with the cleanups inside the appropriate patch?

It's fine this way - i've put them on top - the base patches have a reasonable 
amount of testing track record already, we dont want to destroy that via a 
rebase.

(in the future it's useful to run checkpatch as part of your patch submission 
checks. In my experience it finds real issues most of the time. Some of the 
warnings have to be ignored.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/