linux-kernel - RE: [PATCH 1/7] RapidIO: Add IDT CPS/TSI switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0CE8B6BE3C4AD74AB97D9D29BD24E552A54E7A@CORPEXCH1.na.ads.idt.com>
Date:	Thu, 25 Feb 2010 06:18:49 -0800
From:	"Bounine, Alexandre" <Alexandre.Bounine@....COM>
To:	"Micha Nelissen" <micha@...i.hopto.org>,
	"Alexandre Bounine" <alexb@...dra.com>
Cc:	<mporter@...nel.crashing.org>, <alexandreb@...dra.com>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
	<thomas.moll.ext@....com>, <thomas.moll@...go.com>
Subject: RE: [PATCH 1/7] RapidIO: Add IDT CPS/TSI switches

Micha Nelissen wrote:
> Alexandre Bounine wrote:
> > @@ -369,6 +380,10 @@ static struct rio_dev __devinit *rio_set
> >  			     rdev->rswitch->switchid);
> >  		rio_route_set_ops(rdev);
> >
> > +		if (do_enum && rdev->rswitch->clr_table)
> > +			rdev->rswitch->clr_table(port, destid, hopcount,
> > +						 RIO_GLOBAL_TABLE);
> > +
> >  		list_add_tail(&rswitch->node, &rio_switches);
> >
> >  	} else
> 
> Why clear the tables here, why not in rio_enum_peer?

I prefer to keep it together with route table image initialization. 

> 
> > +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI572,
tsi57x_route_add_entry,
> tsi57x_route_get_entry, tsi57x_route_clr_table);
> > +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI574,
tsi57x_route_add_entry,
> tsi57x_route_get_entry, tsi57x_route_clr_table);
> > +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI577,
tsi57x_route_add_entry,
> tsi57x_route_get_entry, tsi57x_route_clr_table);
> > +DECLARE_RIO_ROUTE_OPS(RIO_VID_TUNDRA, RIO_DID_TSI578,
tsi57x_route_add_entry,
> tsi57x_route_get_entry, tsi57x_route_clr_table);
> 
> Can the 568 and 578 driver be shared? Have a 5xx driver?

For route table operations this will work. But there are Error
Management functions added in follow-up patches, which are different for
Tsi568. I prefer to keep them in different files to avoid hiding the
differences. Plus, it makes easier for end-user to remove from the build
drivers for switches that are not used in their system. I do not want to
add new configuration options for switch selection at this moment but we
may consider it later. 

Alex.
  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/