linux-kernel - Re: [PATCH 03/06] kernel.h hexdump cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100224181646.bde9c183.akpm@linux-foundation.org>
Date:	Wed, 24 Feb 2010 18:16:46 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Li Zefan <lizf@...fujitsu.com>
Subject: Re: [PATCH 03/06] kernel.h hexdump cleanup

On Thu, 25 Feb 2010 09:52:49 +0800 Dave Young <hidave.darkstar@...il.com> wrote:

> On Tue, Feb 23, 2010 at 3:43 AM, Joe Perches <joe@...ches.com> wrote:
> > On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote:
> >> hexdump stuff in kernel.h should be put into a standalone head file
> >
> > I think it'd be clearer to have logging functions
> > in kernel.h split into a separate header or grouped
> > a bit better in kernel.h.
> >
> > I would have kernel.h #include that header though
> > rather than splitting out things like hexdump functions
> > into a separate file requiring yet another #include in
> > source files.
> 
> Andrew, what do you think about this?

Well.  Avoiding bisection-bustage is hardly a priority any more, but
let's not break bisection this time if we can avoid it.

> Actually I hesitate to send this patch as well, too many recipients
> needed from get_maintainer.pl.

They'll live ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/