linux-kernel - Re: [PATCH] x86: Enable NMI on all cpus on UV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100225172447.GC27785@sgi.com>
Date:	Thu, 25 Feb 2010 11:24:47 -0600
From:	Russ Anderson <rja@....com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, rja@....com
Subject: Re: [PATCH] x86: Enable NMI on all cpus on UV

On Mon, Feb 22, 2010 at 11:38:53AM +0100, Ingo Molnar wrote:
> 
> * Russ Anderson <rja@....com> wrote:
> 
> > Enable NMI on all cpus in UV system and add an NMI handler
> > to dump_stack on each cpu.
> > 
> > Signed-off-by: Russ Anderson <rja@....com>
[...]
> >  						 struct mm_struct *mm,
> > Index: linux/arch/x86/kernel/smpboot.c
> > ===================================================================
> > --- linux.orig/arch/x86/kernel/smpboot.c	2010-02-17 10:21:55.000000000 -0600
> > +++ linux/arch/x86/kernel/smpboot.c	2010-02-17 10:32:20.000000000 -0600
> > @@ -320,6 +320,8 @@ notrace static void __cpuinit start_seco
> >  	unlock_vector_lock();
> >  	ipi_call_unlock();
> >  	per_cpu(cpu_state, smp_processor_id()) = CPU_ONLINE;
> > +	if (is_uv_system())
> > +		uv_nmi_init();
> 
> Instead of cramming it into the init sequence open-coded, shouldnt this be 
> done via the x86_platform driver mechanism?

Attached is the updated patch with the x86_platform driver mechanism
used for uv_nmi_init.

> Thanks,
> 
> 	Ingo

-- 
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          rja@....com

View attachment "uv_nmi_handler" of type "text/plain" (6378 bytes)