linux-kernel - Re: [RESEND][PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100225185734.GI28173@atomide.com>
Date:	Thu, 25 Feb 2010 10:57:34 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	"Shilimkar, Santosh" <santosh.shilimkar@...com>
Cc:	Thomas Weber <swirl@....li>, "Aguirre, Sergio" <saaguirre@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Kevin Hilman <khilman@...prootsystems.com>,
	"Pandita, Vikram" <vikram.pandita@...com>,
	"Syed, Rafiuddin" <rafiuddin.syed@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Thomas Weber <weber@...science.de>
Subject: Re: [RESEND][PATCH/RFC] OMAP2: serial.c: Fix number of uarts in
 early_init

* Shilimkar, Santosh <santosh.shilimkar@...com> [100225 10:51]:
> 
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony@...mide.com]
> > Sent: Friday, February 26, 2010 12:14 AM
> > To: Thomas Weber; Aguirre, Sergio
> > Cc: linux-omap@...r.kernel.org; Russell King; Kevin Hilman; Shilimkar, Santosh; Pandita, Vikram;
> > Syed, Rafiuddin; linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Thomas Weber
> > Subject: Re: [RESEND][PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early_init
> > 
> > * Thomas Weber <swirl@....li> [100225 01:36]:
> > >
> > > The omap_serial_early_init prints the following errors:
> > >
> > > Could not get uart4_ick
> > > Could not get uart4_fck
> > >
> > > because all the uarts available in omap_uart[] will be initialized.
> > > Only omap4430 and omap3630 have 4 uarts at the moment.
> > > This patch reduces the number of uarts when cpu is not omap4430 or
> > > omap3630.
> > 
> > ..and I only patched omap_serial_init and forgot about
> > the omap_serial_early_init..
> > 
> > Looks good to me, Sergio, care to test and Ack this? Also, sounds
> > like we still need to patch omap4 for uart4 for the clocks.
> > 
> Clocks will be take care automatically by "nr_ports" for omap4 too
> with this patch. Below clock changes are just cosmetic ones, isn't it ?
> 
> Am I missing something?

Yes sorry, I'm referring to "[RFC][PATCH 0/3] OMAP3630: UART4 startup"
series to fix the uart4 issues for 3630, not omap4.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/