linux-kernel - Re: [PATCH] TOMOYO: Protect find_task_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1002251413160.14411@tundra.namei.org>
Date:	Thu, 25 Feb 2010 14:15:58 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
cc:	linux-security-module@...r.kernel.org,
	Al Viro <viro@....linux.org.uk>, linux-kernel@...r.kernel.org,
	Oleg Nesterov <oleg@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] TOMOYO: Protect find_task_by_vpid() with RCU.

On Thu, 25 Feb 2010, Tetsuo Handa wrote:

> James Morris wrote:
> > On Wed, 24 Feb 2010, Tetsuo Handa wrote:
> > 
> > > Caller of find_task_by_vpid() must use rcu_read_lock().
> > 
> > The comment for the function says:
> > 
> >   Must be called under rcu_read_lock() or with tasklist_lock read-held.
> > 
> > In the cases below, you have taken tasklist_lock.
> 
> That comment will be updated to
> "Must be called under rcu_read_lock()." in 2.6.34 .
> Please see http://lkml.org/lkml/2009/12/10/180 and http://lkml.org/lkml/2009/12/9/472 .

Ok, please fix the comment as well.

Thomas: wasn't Tetsuo correct that we need both the rcu lock and 
tasklist_lock held to call this?

Also, I think the audit code needs fixing.


-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/