linux-kernel - Re: [PATCH] TOMOYO: Protect find_task_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1002260921350.23539@tundra.namei.org>
Date:	Fri, 26 Feb 2010 09:22:18 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
cc:	linux-security-module@...r.kernel.org,
	Al Viro <viro@....linux.org.uk>, linux-kernel@...r.kernel.org,
	oleg@...hat.com, tglx@...utronix.de,
	Andrew Morton <akpm@...ux-foundation.org>,
	Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH] TOMOYO: Protect find_task_by_vpid() with RCU.

On Thu, 25 Feb 2010, Tetsuo Handa wrote:

> I see. Explanation is in commit d4581a239a40319205762b76c01eb6363f277efa
> "sys: Fix missing rcu protection for __task_cred() access".
> Thus, I think below comment should be sufficient.
> --------------------
> [PATCH] TOMOYO: Protect find_task_by_vpid() with RCU.
> 
> Holding tasklist_lock is no longer sufficient for find_task_by_vpid().
> Explicit rcu_read_lock() is required.

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

The audit code still looks like it needs to be updated.

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/