linux-kernel - Re: [PATCH 14/28] kgdboc,keyboard: Keyboard driver for kdb with kgdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Feb 2010 23:57:56 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	kgdb-bugreport@...ts.sourceforge.net
Subject: Re: [PATCH 14/28] kgdboc,keyboard: Keyboard driver for kdb with kgdb

Hi Jason,

Sorry for not responding earlier.

On Thu, Feb 25, 2010 at 03:21:19PM -0600, Jason Wessel wrote:
> +++ b/drivers/char/kdb_keyboard.c

Does it have to live here? If you are going for completely separate
driver maybe it should be buried somewhere like xxx/kdb/kdb_keyboard.c
so nobody needs to look at it?

> diff --git a/drivers/char/kdb_keyboard.h b/drivers/char/kdb_keyboard.h
> new file mode 100644
> index 0000000..5541668
> --- /dev/null
> +++ b/drivers/char/kdb_keyboard.h
> @@ -0,0 +1,143 @@
> +/*
> + *	include/linux/pc_keyb.h
> + *
> + *	PC Keyboard And Keyboard Controller
> + *
> + *	(c) 1997 Martin Mares <mj@...ey.karlin.mff.cuni.cz>
> + */

The above notwithstanding maybe we should not be bringing 2.4 codebase
as is in 2.6 and instead use (and extend as needed) definitions that are
already present?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/