linux-kernel - Re: [PATCH 2/2] vga_switcheroo: initial implementation (v8)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21d7e9971002260050h37eff655k3b667528b9cca333@mail.gmail.com>
Date:	Fri, 26 Feb 2010 18:50:04 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	linux-fbdev@...r.kernel.org, Dave Airlie <airlied@...ux.ie>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.sf.net
Subject: Re: [PATCH 2/2] vga_switcheroo: initial implementation (v8)

Oh I should probably have dropped all the audio bits, I didn't even
see this reply
before I updated to v11.

The r600 audio code is a bit of disaster area hopefully we can clean it up, like
the timer was firing after the device was suspended.

I'll repost with all that r600 audio ripped out and you can fix the mess.
>
> Don't mess with r600_audio_* there. You call if for all chipsets which
> is not needed and break nice S&R layout, which is chipset specific.
>
> I guess you needed that because you didn't work on branch containing my patch:
> http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=38fd2c6ff526e6a59edfa8e08f6f0724646784c4
> (you commited it to drm-linus)

This patch is now based on Linus tree, but yeah the original version
predates your
patches.

>> -int radeon_audio = 1;
>> +int radeon_audio = 0;
>
> Why?! What for we disable this feature by default?! If you see some
> reason for that, explain it to others please. I can change my mind,
> but for now I don't like this. It makes audio an option from just
> working-out-of-box.
>

Oversights, the audio was just broken in the presence of suspend/resume when
I wrote it.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/