linux-kernel - Re: [PATCH net-next 1/7] drivers/net/chelsio: Use pr_<level>, netif_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100226.014010.239722623.davem@davemloft.net>
Date:	Fri, 26 Feb 2010 01:40:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/7] drivers/net/chelsio: Use pr_<level>,
 netif_msg_<type>

From: Joe Perches <joe@...ches.com>
Date: Mon, 22 Feb 2010 18:56:57 -0800

> Convert CH_<level> and CH_DBG uses to pr_<level> and netif equivalents
> Remove CH_<level> and CH_DBG macro definitions
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied, thanks Joe.

BTW:

> @@ -734,8 +734,9 @@ int t1_elmer0_ext_intr_handler(adapter_t *adapter)
>  		break;
>  	case CHBT_BOARD_8000:
>  	case CHBT_BOARD_CHT110:
> -		CH_DBG(adapter, INTR, "External interrupt cause 0x%x\n",
> -		       cause);
> +		if (netif_msg_intr(adapter))
> +			dev_dbg(&adapter->pdev->dev, 

Trailing whitespace on that last line.  I fixed it up when
adding the patch to my tree.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/