linux-kernel - Re: [PATCH -next] staging/pohmelfs: fix write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100226114118.097a2470.sfr@canb.auug.org.au>
Date:	Fri, 26 Feb 2010 11:41:18 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	devel@...verdev.osuosl.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, gregkh@...e.de,
	Evgeniy Polyakov <zbr@...emap.net>
Subject: Re: [PATCH -next] staging/pohmelfs: fix write_inode parameter
 warning

Hi Randy,

On Thu, 25 Feb 2010 14:41:22 -0800 Randy Dunlap <randy.dunlap@...cle.com> wrote:
>
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> sparse warns that:
> drivers/staging/pohmelfs/inode.c:1797: warning: initialization from incompatible pointer type
> 
> so fix pohmelfs_write_inode() to have the expected parameters.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/staging/pohmelfs/inode.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20100225.orig/drivers/staging/pohmelfs/inode.c
> +++ linux-next-20100225/drivers/staging/pohmelfs/inode.c
> @@ -396,7 +396,8 @@ int pohmelfs_remove_child(struct pohmelf
>  /*
>   * Writeback for given inode.
>   */
> -static int pohmelfs_write_inode(struct inode *inode, int sync)
> +static int pohmelfs_write_inode(struct inode *inode,
> +				struct writeback_control *wbc)
>  {
>  	struct pohmelfs_inode *pi = POHMELFS_I(inode);
>  

This patch is OK, but depends on changes that are in the vfs tree that
are not in Linus' tree yet.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped