linux-kernel - Re: [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and kfree issue found by checkpatch.pl tool Signed-off-by: Graham M Howe<gman.1352@...glemail.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100225235054.GE24155@kroah.com>
Date:	Thu, 25 Feb 2010 15:50:54 -0800
From:	Greg KH <greg@...ah.com>
To:	Graham M Howe <gman.1352@...glemail.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Staging: comedi: fix bracing and kfree issue in
 ni_670x.c This is a patch to the ni_670x.c file that fixes up brace and
 kfree issue found by checkpatch.pl tool Signed-off-by: Graham M
 Howe<gman.1352@...glemail.com>

The subject doesn't match what the patch did :(

On Sat, Feb 20, 2010 at 11:53:01AM +0000, Graham M Howe wrote:
> ---
>  drivers/staging/comedi/drivers/ni_670x.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c
> index fc5f90f..352b917 100644
> --- a/drivers/staging/comedi/drivers/ni_670x.c
> +++ b/drivers/staging/comedi/drivers/ni_670x.c
> @@ -221,8 +221,6 @@ static int ni_670x_detach(struct comedi_device *dev)
>  {
>  	printk("comedi%d: ni_670x: remove\n", dev->minor);
> 
> -	if (dev->subdevices[0].range_table_list)
> -		kfree(dev->subdevices[0].range_table_list);

You can't just not free the memory :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/