lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Feb 2010 12:56:32 GMT From: "tip-bot for Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> To: linux-tip-commits@...r.kernel.org Cc: linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com, hpa@...or.com, mingo@...hat.com, tglx@...utronix.de, mingo@...e.hu Subject: [tip:core/rcu] rcu: Fix accelerated GPs for last non-dynticked CPU Commit-ID: 71da81324c83ef65bb196c7f874ac1c6996d8287 Gitweb: http://git.kernel.org/tip/71da81324c83ef65bb196c7f874ac1c6996d8287 Author: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> AuthorDate: Fri, 26 Feb 2010 16:38:58 -0800 Committer: Ingo Molnar <mingo@...e.hu> CommitDate: Sat, 27 Feb 2010 09:53:53 +0100 rcu: Fix accelerated GPs for last non-dynticked CPU This patch disables irqs across the call to rcu_needs_cpu(). It also enforces a hold-off period so that the idle loop doesn't softirq itself to death when there are lots of RCU callbacks in flight on the last non-dynticked CPU. Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> Cc: laijs@...fujitsu.com Cc: dipankar@...ibm.com Cc: mathieu.desnoyers@...ymtl.ca Cc: josh@...htriplett.org Cc: dvhltc@...ibm.com Cc: niv@...ibm.com Cc: peterz@...radead.org Cc: rostedt@...dmis.org Cc: Valdis.Kletnieks@...edu Cc: dhowells@...hat.com LKML-Reference: <1267231138-27856-3-git-send-email-paulmck@...ux.vnet.ibm.com> Signed-off-by: Ingo Molnar <mingo@...e.hu> --- kernel/rcutree_plugin.h | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h index ed241fc..464ad2c 100644 --- a/kernel/rcutree_plugin.h +++ b/kernel/rcutree_plugin.h @@ -986,6 +986,7 @@ static void rcu_needs_cpu_flush(void) #define RCU_NEEDS_CPU_FLUSHES 5 static DEFINE_PER_CPU(int, rcu_dyntick_drain); +static DEFINE_PER_CPU(unsigned long, rcu_dyntick_holdoff); /* * Check to see if any future RCU-related work will need to be done @@ -1013,6 +1014,7 @@ int rcu_needs_cpu(int cpu) for_each_cpu_not(thatcpu, nohz_cpu_mask) if (thatcpu != cpu) { per_cpu(rcu_dyntick_drain, cpu) = 0; + per_cpu(rcu_dyntick_holdoff, cpu) = jiffies - 1; return rcu_needs_cpu_quick_check(cpu); } @@ -1022,6 +1024,7 @@ int rcu_needs_cpu(int cpu) per_cpu(rcu_dyntick_drain, cpu) = RCU_NEEDS_CPU_FLUSHES; } else if (--per_cpu(rcu_dyntick_drain, cpu) <= 0) { /* We have hit the limit, so time to give up. */ + per_cpu(rcu_dyntick_holdoff, cpu) = jiffies; return rcu_needs_cpu_quick_check(cpu); } @@ -1038,8 +1041,10 @@ int rcu_needs_cpu(int cpu) } /* If RCU callbacks are still pending, RCU still needs this CPU. */ - if (c) + if (c) { raise_softirq(RCU_SOFTIRQ); + per_cpu(rcu_dyntick_holdoff, cpu) = jiffies; + } return c; } @@ -1050,10 +1055,13 @@ int rcu_needs_cpu(int cpu) static void rcu_needs_cpu_flush(void) { int cpu = smp_processor_id(); + unsigned long flags; if (per_cpu(rcu_dyntick_drain, cpu) <= 0) return; + local_irq_save(flags); (void)rcu_needs_cpu(cpu); + local_irq_restore(flags); } #endif /* #else #if !defined(CONFIG_RCU_FAST_NO_HZ) */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists